Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme Updates III #574

Merged
merged 17 commits into from Jun 22, 2013
Merged

Theme Updates III #574

merged 17 commits into from Jun 22, 2013

Conversation

Spuds
Copy link
Contributor

@Spuds Spuds commented Jun 22, 2013

This one should fix #517, definitely fixes #565, and catches the last stragglers of the quickbuttons elements' new classes that I missed earlier.

Also has lotsa other goodies, including the start of the CSS split that was posted about here.

There are a couple of readmes (very short ones) tucked in the zip.

Antechinus added 17 commits June 22, 2013 08:47
Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
! doctype change to html5

Signed-off-by: Spuds <spuds@spudsdesign.com>
! remove dropdown from quote quickbutton

Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
! overly complicate a simple class selection for locked/stikcy backgrounds
! Moved some img stuff around, hard to tell what it does from the changed window so ask Ant /me is just a secretary and not a good one at that :D

Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
…main css

Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
… code cuz

Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
@StealthWombat
Copy link
Contributor

Yeah, it needed a good dose of intelligibility. Can still get better (and will).

PR looks good. AFAICT it caught everything it should have. If it didn't, can sort it with the next one.

@norv
Copy link
Contributor

norv commented Jun 22, 2013

Hah @ https://github.com/Spuds/Elkarte/blob/d805c3548e4a60efbb9cf5c0a408fcde94bafdf6/themes/default/images/_basic/on.png. So, still found a place for teh moose? 🔮

Thanks Ant, I'll merge it in asap, to take advantage of and put it up for grumbles, err, test.
Thank you SpudsMan for the work on it. Split in focused commits, even partially, it's better in history and for the future changes/bugs/tweaks.

norv added a commit that referenced this pull request Jun 22, 2013
@norv norv merged commit 9ea2535 into elkarte:master Jun 22, 2013
@StealthWombat
Copy link
Contributor

Teh moose is still there becase I haven't heard back from the dude who did the groovy green folder. Figure we shouldn't put it in the repo if licensing isn't sorted.

If I don't hear from him soon, I'll arrange another icon.

Will grab this lot and start testing. Will try to keep future code dumps less complex.

@Spuds Spuds deleted the AIII branch June 23, 2013 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants