Add extra padding for ByteArray after encoding #3157
Merged
+15
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently String#encode produces an ill-state string in some cases.
In all other places, String allocates its internal ByteArray buffer with size + 1. Follow the rule here too.
This bug causes the following mysterious error (was hard to track down…):
The reproducible code
Before
After
(*The final ByteArray size is aligned by ObjectHeader::align)