Created JUnit test for HibernateFormDAO.getFormCriteria's containingAnyF... #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nyFormField parameter- TRUNK-3195
|
@sashrika does mvn clean install work without errors on your side? |
|
@dkayiwa, When I removed this two test cases, mvn clean install work without errors on my side(that means without any modification to the original cloned copy). I doubt whether https://tickets.openmrs.org/browse/TRUNK-4189 is fixed correctly. Any ideas? |
|
@dkayiwa I checked https://travis-ci.org/openmrs/openmrs-core/jobs/18668823, the reason for the build failure is my junit test. |
|
@sashrika you are right about this. I have made a follow up fix for TRUNK-4189 |
|
@dkayiwa Great :) . I'll try again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created JUnit test for HibernateFormDAO.getFormCriteria's containingAnyFormField parameter
https://tickets.openmrs.org/browse/TRUNK-3195