added testing attribute to Mojo::Log

mojolicious · Apr 25, 2013 · 072a3d5 · 072a3d5
1 parent bc4ac25
commit 072a3d5
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/lib/Mojo/Log.pm b/lib/Mojo/Log.pm
@@ -3,6 +3,7 @@ use Mojo::Base 'Mojo::EventEmitter';
 
 use Carp 'croak';
 use Fcntl ':flock';
+use Test::More ();
 
 has handle => sub {
 
@@ -19,6 +20,7 @@ has handle => sub {
 };
 has level => 'debug';
 has 'path';
+has testing => sub { $ENV{HARNESS_ACTIVE} };
 
 # Supported log level
 my $LEVEL = {debug => 1, info => 2, warn => 3, error => 4, fatal => 5};
@@ -62,8 +64,9 @@ sub _message {
   return unless $self->is_level($level) && (my $handle = $self->handle);
 
   flock $handle, LOCK_EX;
-  croak "Can't write to log: $!"
-    unless defined $handle->syswrite($self->format($level, @lines));
+  my $msg = $self->format($level, @lines);
+  if ($self->testing) { Test::More::diag $msg }
+  else { defined $handle->syswrite($msg) or croak "Can't write to log: $!" }
   flock $handle, LOCK_UN;
 }
 
@@ -157,6 +160,14 @@ These levels are currently available:
 
 Log file path used by C<handle>.
 
+=head2 testing
+
+  my $testing = $log->testing;
+  $log        = $log->testing(0);
+
+Output log messages as diagnostics information through L<Test::More>, defaults
+to the value of the HARNESS_ACTIVE environment variable.
+
 =head1 METHODS
 
 L<Mojo::Log> inherits all methods from L<Mojo::EventEmitter> and implements

diff --git a/t/mojo/log.t b/t/mojo/log.t
@@ -9,7 +9,7 @@ use Mojo::Util 'slurp';
 # Logging to file
 my $dir = tempdir CLEANUP => 1;
 my $path = catdir $dir, 'test.log';
-my $log = Mojo::Log->new(level => 'error', path => $path);
+my $log = Mojo::Log->new(level => 'error', path => $path, testing => 0);
 $log->error('Just works.');
 $log->fatal('Works too.');
 $log->debug('Does not work.');