Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Named subject #9

Closed
wants to merge 2 commits into from
Closed

Named subject #9

wants to merge 2 commits into from
+12 −0

Conversation

wasnotrice
Copy link

I've got some specs that use the "named subject" syntax

subject(:name) { Foo.new }

opal-rspec doesn't like this syntax, though. This pull request adds some failing specs for that syntax. I'd love some guidance about how to make the spec pass.

$ bundle exec rake

Failures:


  1) named subject should be the subject
     NotImplementedError:
       `super` in named subjects is not supported


  2) named subject should be the named subject
     NotImplementedError:
       `super` in named subjects is not supported

61 examples, 2 failures (time taken: 1.105)

@wasnotrice
Add failing spec for named subject

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
59c8d9a
@wasnotrice
Add failing spec for named subject
54152b7 
subject and named_subject should be the same object
@adambeynon
Copy link
Contributor

Been digging into this today, and it seems to be an error inside Opal's module system, where a method is not being redefined properly. I will keep having a go to fix it, but it looks to be a really subtle bug and quite difficult to track down.

@adambeynon adambeynon self-assigned this Nov 26, 2014
@adambeynon
Copy link
Contributor

Ref: https://github.com/rspec/rspec-core/blob/7c5d508bebf64c7f00b9d7d63ad1114ef481914c/lib/rspec/core/memoized_helpers.rb#L338-L349

@adambeynon adambeynon mentioned this pull request Nov 26, 2014
Closed
@adambeynon
Copy link
Contributor

So, this is now fixed on opal/opal master.

@adambeynon adambeynon closed this Nov 27, 2014
@wasnotrice
Copy link
Author

Awesome. Thank you! Very subtle indeed! Can't wait to try out the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adambeynon adambeynon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wasnotrice @adambeynon