Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution for Trunk-4283 #705

Closed
wants to merge 1 commit into from
Closed

Solution for Trunk-4283 #705

wants to merge 1 commit into from

Conversation

akshika47
Copy link
Contributor

No description provided.

@dkayiwa
Copy link
Member

dkayiwa commented Mar 4, 2014

@akshika47 can you use more meaningful messages that simply "Solution for Trunk-4283"?
The message should indicate what you are trying to do on the ticket. At least you rather use the JIRA ticket summary. :)

@akshika47
Copy link
Contributor Author

I will do it from next pull request. Can you merge this one :)

@dkayiwa
Copy link
Member

dkayiwa commented Mar 5, 2014

@akshika47 did you actually try run the webapp to test this changeset and see it halt the upgrade process?

wluyima
wluyima reviewed Mar 6, 2014
View reviewed changes
api/src/main/resources/liquibase-schema-only.xml
@@ -1837,6 +1837,14 @@
<replace replace="CHAR(38)" with="UNIQUEIDENTIFIER NOT NULL DEFAULT NEWSEQUENTIALID()" />
</modifySql>
</changeSet>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in a wrong file, should be in liquibase-update-to-latest.xml

@ghost
Copy link

ghost commented Mar 6, 2014

Please use more a descriptive pull request title, similar to that as described for commit messages in https://wiki.openmrs.org/display/docs/Using+Git under step 3 in section "Work on your task".

@akshika47
Copy link
Contributor Author

Yes, I will, Sorry about it, this commit was done a time before. Before
Daniel asked me to do so. I will do in that manner next time for sure.

On Thu, Mar 6, 2014 at 7:19 PM, Michael Downey notifications@github.comwrote:

Please use more a descriptive pull request title, similar to that as
described for commit messages in
https://wiki.openmrs.org/display/docs/Using+Git under step 3 in section
"Work on your task".

Reply to this email directly or view it on GitHubhttps://github.com//pull/705#issuecomment-36888974
.

Akshika Wijesundara
Department of Computer Science & Engineering
University of Moratuwa
Sri Lanka,

@wluyima wluyima closed this Mar 13, 2014
RandilaP pushed a commit to RandilaP/openmrs-core that referenced this pull request Jul 31, 2023
@vasharma05
(feat) Improved {locale}.json translation files for various languages (…
06cda62 
…openmrs#705)

* Added various languages to parse when extracting translations

* Updated translations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@akshika47 @dkayiwa @wluyima