Small additions for testing #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l function because test failed from the beginning with them. ;D Signed-off-by: Norv <a.w.norv@gmail.com>
Signed-off-by: Norv <a.w.norv@gmail.com>
Signed-off-by: Norv <a.w.norv@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick and dirty: I'd rather make these changes, in particular the flag to disable tests by default, just to avoid running them inadvertently on a database. Tests should not use directly the installed database (use their own if any) and undo what they do, so that even between tests nothing is affected. I've been using SSI for starters, which is to say it's more integration tests (of the whole application).
Functions working with the db aren't exactly "units", but IMHO usefulness and trying to cover our code bypasses strictness on this. Test what we can and we're up to, and leave the strictness behind on this bit. Improve them as we go. But we need to be careful what we're running them on. (and leave the db in a consistent state)