small optimizations

mojolicious · May 8, 2013 · 440634d · 440634d
1 parent 0f642bf
commit 440634d
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/lib/Mojo/Transaction/WebSocket.pm b/lib/Mojo/Transaction/WebSocket.pm
@@ -296,12 +296,10 @@ sub _message {
   my $msg = delete $self->{message};
   $self->emit(json => Mojo::JSON->new->decode($msg))
     if $self->has_subscribers('json');
-  if (delete $self->{op} == TEXT) {
-    $self->emit(text => $msg);
-    $msg = decode 'UTF-8', $msg;
-  }
-  else { $self->emit(binary => $msg); }
-  $self->emit(message => $msg);
+  $op = delete $self->{op};
+  $self->emit($op == TEXT ? 'text' : 'binary' => $msg);
+  $self->emit(message => $op == TEXT ? decode('UTF-8', $msg) : $msg)
+    if $self->has_subscribers('message');
 }
 
 1;
@@ -418,7 +416,8 @@ gets emitted when it has at least one subscriber.
   });
 
 Emitted when a complete WebSocket message has been received, text messages
-will be automatically decoded.
+will be automatically decoded. Note that this event only gets emitted when it
+has at least one subscriber.
 
   $ws->on(message => sub {
     my ($ws, $msg) = @_;