small optimizations

mojolicious · Apr 16, 2012 · b1492d9 · b1492d9
1 parent e23f582
commit b1492d9
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 21 deletions.
diff --git a/lib/Mojolicious/Commands.pm b/lib/Mojolicious/Commands.pm
@@ -131,7 +131,7 @@ sub start_app {
 
 sub _command {
   my $module = shift;
-  if (my $e = Mojo::Loader->load($module)) { return ref $e ? die $e : undef }
+  if (my $e = Mojo::Loader->load($module)) { ref $e ? die $e : return }
   return $module->isa('Mojo::Command') ? $module : undef;
 }
 

diff --git a/lib/Mojolicious/Plugin/PODRenderer.pm b/lib/Mojolicious/Plugin/PODRenderer.pm
@@ -68,7 +68,7 @@ sub register {
         }
       );
 
-      # Rewrite code sections for syntax highlighting
+      # Rewrite code blocks for syntax highlighting
       $dom->find('pre')->each(
         sub {
           my $e = shift;
@@ -82,16 +82,16 @@ sub register {
 
       # Rewrite headers
       my $url = $self->req->url->clone;
-      my @sections;
+      my @parts;
       $dom->find('h1, h2, h3')->each(
         sub {
           my $e = shift;
           my $anchor = my $text = $e->all_text;
           $anchor =~ s/\s+/_/g;
           $anchor = url_escape $anchor, 'A-Za-z0-9_';
           $anchor =~ s/\%//g;
-          push @sections, [] if $e->type eq 'h1' || !@sections;
-          push @{$sections[-1]}, $text, $url->fragment($anchor)->to_abs;
+          push @parts, [] if $e->type eq 'h1' || !@parts;
+          push @{$parts[-1]}, $text, $url->fragment($anchor)->to_abs;
           $e->replace_content(
             $self->link_to(
               $text => $url->fragment('toc')->to_abs,
@@ -108,11 +108,7 @@ sub register {
 
       # Combine everything to a proper response
       $self->content_for(perldoc => "$dom");
-      $self->render(
-        inline   => $PERLDOC,
-        title    => $title,
-        sections => \@sections
-      );
+      $self->render(inline => $PERLDOC, title => $title, parts => \@parts);
       $self->res->headers->content_type('text/html;charset="UTF-8"');
     }
   ) unless $conf->{no_perldoc};

diff --git a/lib/Mojolicious/Plugins.pm b/lib/Mojolicious/Plugins.pm
@@ -60,10 +60,7 @@ sub _load {
   my ($self, $module) = @_;
 
   # Load
-  if (my $e = Mojo::Loader->load($module)) {
-    die $e if ref $e;
-    return;
-  }
+  if (my $e = Mojo::Loader->load($module)) { ref $e ? die $e : return }
 
   # Module is a plugin
   return $module->isa('Mojolicious::Plugin') ? 1 : undef;

diff --git a/lib/Mojolicious/templates/perldoc.html.ep b/lib/Mojolicious/templates/perldoc.html.ep
@@ -69,15 +69,13 @@
       <div id="perldoc">
         <h1><a id="toc">TABLE OF CONTENTS</a></h1>
         <ul>
-          % for my $section (@$sections) {
+          % for my $part (@$parts) {
             <li>
-              %= $link->(splice @$section, 0, 2)
-              % if (@$section) {
+              %= $link->(splice @$part, 0, 2)
+              % if (@$part) {
                 <ul>
-                  % while (@$section) {
-                    <li>
-                      %= $link->(splice @$section, 0, 2)
-                    </li>
+                  % while (@$part) {
+                    <li><%= $link->(splice @$part, 0, 2) %></li>
                   % }
                 </ul>
               % }