Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin security enhancements #657

Merged
merged 7 commits into from Jul 15, 2013
Merged

Admin security enhancements #657

merged 7 commits into from Jul 15, 2013

Conversation

eurich
Copy link
Member

@eurich eurich commented Jul 11, 2013

partially covers #389, please do not merge yet..
need someone to check the english text strings.. huh, my english still s*cks..

…n interface. set the default lifetime to ten minutes for security reasons.

Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
@eurich
Copy link
Member Author

eurich commented Jul 13, 2013

ok, I'm currently working on the other part (big warning box at the top) .. Need a text for the warning box, though.

This is what I currently have:

You have an active admin session in place. This is a possible security risk. Be sure to end the session once you have finished your administrative tasks.

I'm open for suggestions.

@ghost
Copy link

ghost commented Jul 13, 2013

Security risk is overloaded...

You have an active admin session in place. We recommend to end this session once you have finished your administrative tasks.

IMHO, a warning is good, but not too scary...

@eurich
Copy link
Member Author

eurich commented Jul 13, 2013

thanks.
admin_warning
Personally I think it's not too scary at all, is it?

@ghost
Copy link

ghost commented Jul 13, 2013

No, it's perfect! 👍

…ession.

Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
…itialized during logon or not..

Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
@emanuele45
Copy link
Contributor

Maybe something similar could be applied to the moderate session too?
Or is it overkill?

@StealthWombat
Copy link
Contributor

Umm, are you really thinking of putting that right on top of the board index all the time? I'd regard it as damned annoying, and a mark against the app. If you want it in the admin centre itself, maybe. Not everywhere though. That's too much, IMO.

ETA: Either we'll have to find a way to make it less ugly, or people will be asking how to hack it out.

@eurich
Copy link
Member Author

eurich commented Jul 14, 2013

Mod center: Dunno.. the moderation center is IMHO not that critical..

@StealthWombat: That bar is only visible with an active admin session, not all the time..
inactive_session
As you can see: I'm logged in with an administrative account (the admin button is visible) but the admin session is not active.

@norv
Copy link
Contributor

norv commented Jul 14, 2013

Thank you! This is cool for the Elk to do.

@eurich
Copy link
Member Author

eurich commented Jul 15, 2013

Ssomeone objections or can we merge?

norv added a commit that referenced this pull request Jul 15, 2013
@norv norv merged commit 3b95338 into elkarte:master Jul 15, 2013
@eurich eurich mentioned this pull request Jul 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants