Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5791b43af762
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6259dff6d06e
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Mar 11, 2015

  1. [Truffle] Untagged passing String specs.

    @nirvdrum
    nirvdrum committed Mar 11, 2015
    Copy the full SHA
    2fede29 View commit details

  2. Delegate to prevent some code duplication.

    @nirvdrum
    nirvdrum committed Mar 11, 2015
    Copy the full SHA
    6259dff View commit details
Showing with 1 addition and 3 deletions.
  1. +1 −1 core/src/main/java/org/jruby/RubyString.java
  2. +0 −2 spec/truffle/tags/core/string/rindex_tags.txt
2 changes: 1 addition & 1 deletion core/src/main/java/org/jruby/RubyString.java
View file
Original file line number Diff line number Diff line change
@@ -267,7 +267,7 @@ final boolean singleByteOptimizable() {
}

final boolean singleByteOptimizable(Encoding enc) {
return getCodeRange() == CR_7BIT || enc.maxLength() == 1;
return StringSupport.isSingleByteOptimizable(this, enc);
}

// rb_enc_compatible
2 changes: 0 additions & 2 deletions spec/truffle/tags/core/string/rindex_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
fails:String#rindex with object tries to convert obj to a string via to_str
fails:String#rindex with String behaves the same as String#rindex(char) for one-character strings
fails:String#rindex with String behaves the same as String#rindex(?char) for one-character strings
fails:String#rindex with String tries to convert start_offset to an integer via to_int
fails:String#rindex with Regexp behaves the same as String#rindex(string) for escaped string regexps
fails:String#rindex with Regexp returns the index of the first match from the end of string of regexp