I merged this to take advantage of the fixes now. (too many errors!)

Never mind it seems !

Looking at these it seems that the cache on the totals is very needed, the one on the menu seems less relevant.

Please keep in mind that moderation as it is today, is quite limited. When we will want more features to it (moderator groups, some request on follow-ups, etc), a cache in session will help more. Perhaps we could (i.e. next time we'd have a proposal for moderation features) look into extending the mod cache, and use it for any extra info needed. Let me know if I'm missing the point of the discussion here; I think this was the reason for the mod cache in the first place. (and not as much the numbers alone, although on those I'd say it proves its value.)

Yeah, I think you are talking about another cache... ;)

We are talking just about the "normal" cache_get_data and cache_put_data. :)

Ignore it then. I read too fast, bad things can happen when I do that!

Just a few quick thoughts on caching the menu: there must be many keys not matching for users other than regular users and guests, even if the menu will be the same; not all groups are relevant for menu, possibly by far. OTOH, boardsAllowedTo() is called by loadModeratorMenuCounts().