Skip to content

Commit

Permalink
Showing 5 changed files with 2 additions and 28 deletions.
1 change: 1 addition & 0 deletions spec/truffle/tags/core/random/new_tags.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
fails:Random.new returns a new instance of Random
fails:Random.new uses a random seed value if none is supplied
fails:Random.new returns Random instances initialized with different seeds
fails:Random.new accepts an Integer seed value as an argument
3 changes: 1 addition & 2 deletions truffle/src/main/java/org/jruby/truffle/nodes/RubyTypes.java
Original file line number Diff line number Diff line change
@@ -53,8 +53,7 @@
RubyEncoding.class, //
RubySymbol.class, //
RubyThread.class, //
RubyTime.class,
RubyRandom.class, //
RubyTime.class, //
RubyEncodingConverter.class, //
RubyMethod.class, //
RubyUnboundMethod.class, //

This file was deleted.

Original file line number Diff line number Diff line change
@@ -98,7 +98,6 @@ public class CoreLibrary {
private final RubyClass securityErrorClass;
private final RubyClass standardErrorClass;
private final RubyClass stringClass;
private final RubyClass randomClass;
private final RubyClass stringDataClass;
private final RubyClass symbolClass;
private final RubyClass syntaxErrorClass;
@@ -285,7 +284,6 @@ public CoreLibrary(RubyContext context) {
rangeClass = defineClass("Range", new RubyRange.RangeAllocator());
regexpClass = defineClass("Regexp", new RubyRegexp.RegexpAllocator());
stringClass = defineClass("String", new RubyString.StringAllocator());
randomClass = defineClass("Random");
symbolClass = defineClass("Symbol");
threadClass = defineClass("Thread", new RubyThread.ThreadAllocator());
timeClass = defineClass("Time", new RubyTime.TimeAllocator());

This file was deleted.

3 comments on commit 8bfaa93

@nirvdrum
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucasallan I think you and @chrisseaton discussed moving this to Rubinius. If I'm wrong about that, apologies for the revert. However, this was causing a FindBugs issue and as such, failing the build on Travis.

@lucasallan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nirvdrum Yes, we have discussed it and I have a pull request almost ready (with the rubinius code). Thank you for revert it and apologize for the mistake.

@nirvdrum
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. I just wanted to make sure I didn't misunderstand.

Please sign in to comment.