getaddrinfo returns ENOTFOUND for invalid domain names

change test-http-dns-error to reflect this.
nodejs · Oct 21, 2011 · d5a21a2 · d5a21a2
1 parent efa95c2
commit d5a21a2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/dns.js b/lib/dns.js
@@ -32,7 +32,7 @@ function errnoException(errorno, syscall) {
 
   // For backwards compatibility. libuv returns ENOENT on NXDOMAIN.
   if (errorno == 'ENOENT') {
-    errorno = 'EBADNAME'
+    errorno = 'ENOTFOUND'
   }
 
   e.errno = e.code = errorno;

diff --git a/test/simple/test-http-dns-error.js b/test/simple/test-http-dns-error.js
@@ -46,14 +46,14 @@ function test(mod) {
   // Ensure that there is time to attach an error listener.
   var req = mod.get({host: host, port: 42}, do_not_call);
   req.on('error', function(err) {
-    assert.equal(err.code, 'EBADNAME');
+    assert.equal(err.code, 'ENOTFOUND');
     actual_bad_requests++;
   });
   // http.get() called req.end() for us
 
   var req = mod.request({method: 'GET', host: host, port: 42}, do_not_call);
   req.on('error', function(err) {
-    assert.equal(err.code, 'EBADNAME');
+    assert.equal(err.code, 'ENOTFOUND');
     actual_bad_requests++;
   });
   req.end();