TRUNK-4116 #450
Closed
TRUNK-4116 #450
+106
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
November 13, 2013 16:44
…rue and DrugName is not null to search drugs with the words of drugName
…se, false, null, null)
…d getDrugs(phrase)
…return drugs included retired
|
@pamcdm can you pull the latest changes from upstream, then do an "mvn clean install" to see if all is well? |
|
@pamcdm just reopen this pull request when you are done addressing the above comments. :) |
RandilaP
pushed a commit
to RandilaP/openmrs-core
that referenced
this pull request
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We left getDrugs(String phrase) as is but change the existing getDrugs(String drugName, Concept concept, boolean searchOnPhrase, boolean searchDrugConceptNames, boolean includeRetired, Integer start, Integer length) so that it performs the same sort of query as getDrugs(String phrase)--that is, it if "searchOnPhrase=true" is breaks up the passed in drugName string and parses it into individual words and adds each word as an ilike queries Restriction separately. Since the different implementations of getDrugs accept and others don't return retired drugs, couldn't have an agreement without impact the current behaviour.