[Truffle] Fixed class variable lookup from singleton classes by attaching their companion class to them. #2667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hing their companion class to them.
| if (value != null) { | ||
| return value; | ||
| } | ||
| } |
There was a problem hiding this comment.
We should not check both ancestry chains. MRI lookup is at https://github.com/ruby/ruby/blob/badb4de72a08b199f1a63864531d47beafca818b/variable.c#L2355-L2384.
So, I would add the if attached above the ancestors lookup, and in that if do the lookup on the attached module and set module to the attached module.
There was a problem hiding this comment.
Thanks. I thought it occurred afterwards.
|
Looks good, please see my two and I think we'll have the perfect commit 😄 |
nirvdrum
added a commit
that referenced
this pull request
Mar 9, 2015
[Truffle] Fixed class variable lookup from singleton classes by attaching their companion class to them.
|
Thanks again for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@eregon I made the changes we discussed. Any additional feedback would be great.