Versions #2211
Merged
Versions #2211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That much cleaner - thanks very much for taking the time to do that. I think the |
|
just saw that jruby/jruby-rack uses ".SNAPSHOT" for their gems: https://github.com/jruby/jruby-rack/blob/1.1-stable/Rakefile#L131 maybe to keep things even consistent over the various jruby projects ? |
|
Which are you proposing we change? jruby or jruby-rack? I'm not sure if .snapshot or .SNAPSHOT looks more conventional for a gem so don't have an opinion. |
|
to change jruby-rack means we need to take the discussion to jruby-rack and please feel free to merge the PR any time when need |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is meant to resolve the issue #2206
all artifacts follow the version in the file VERSION beside the jruby-jars gems where '-SNAPSHOT' gets converted to '.snapshot'