[Truffle] Adding #to_int to Array#at paramters. #2685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -446,10 +449,11 @@ public Object setIntegerFixnumRange(VirtualFrame frame, RubyArray array, RubyRan | |||
|
|
|||
| } | |||
|
|
|||
| @CoreMethod(names = "at", required = 1, lowerFixnumParameters = 0) | |||
There was a problem hiding this comment.
Safe to remove this?
There was a problem hiding this comment.
Per my comment on the PR, I think this should stay and a new specialization for double added.
|
We could have |
bjfish
force-pushed
the
truffle_array_at
branch
from
6f36fe5
to
e492774
Compare
nirvdrum
added a commit
that referenced
this pull request
Mar 11, 2015
[Truffle] Adding #to_int to Array#at paramters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed lowerFixnumParameter because it wasn’t handling double.
I’m not sure if the guard is needed?