Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 528a3ce3ed0d
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 1d2fab37e61d
Choose a head ref
  • 5 commits
  • 14 files changed
  • 2 contributors

Commits on Feb 5, 2014

  1. src: update MakeCallback() function prototype

    Make it possible to invoke MakeCallback() on a v8::Value but only for
    the variant that takes a v8::Function as the thing to call.
    
    The const char* and v8::String variants still require a v8::Object
    because the function to call is looked up as a property on the receiver,
    but that only works when the receiver is an object, not a primitive.
    bnoordhuis authored and tjfontaine committed Feb 5, 2014
    Copy the full SHA
    1f2f3fa View commit details
    Browse the repository at this point in the history
  2. src: fix MakeCallback() handle leak

    Create a new HandleScope before looking up the object context with
    v8::Object::CreationContext(), else we leak the Local<Context> into
    the current HandleScope.
    
    That's relatively harmless unless the HandleScope is long-lived and
    MakeCallback() is called a lot.  In a scenario like that, we may end
    up leaking a lot of memory.
    
    What is unfortunate about this change is that we're trying hard to
    eradicate the node_isolate global.  Longer term, we will probably have
    to change the MakeCallback() prototype to one that requires an explicit
    v8::Isolate* argument.
    bnoordhuis authored and tjfontaine committed Feb 5, 2014
    Copy the full SHA
    4dc6f4a View commit details
    Browse the repository at this point in the history
  3. src: add tracing.v8.on('gc') statistics hooks

    Add a new 'tracing' module with a v8 property that lets the user
    register listeners for gc events.  The listeners are invoked after
    every garbage collection cycle with 'before' and 'after' statistics.
    Useful for monitoring tools that want to keep track of memory usage.
    bnoordhuis authored and tjfontaine committed Feb 5, 2014
    Copy the full SHA
    010222d View commit details
    Browse the repository at this point in the history
  4. src: add v8.getHeapStatistics() function

    Add a one-to-one binding to v8::GetHeapStatistics().  Returns info on
    the current state of the JS heap, like total size and amount used.
    bnoordhuis authored and tjfontaine committed Feb 5, 2014
    Copy the full SHA
    d23ac0e View commit details
    Browse the repository at this point in the history
  5. 2
    Copy the full SHA
    1d2fab3 View commit details
    Browse the repository at this point in the history