"core" target fixes #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Further pondering reminds me that the "core" target with the workaround only works for "dynamic". Likewise, the "coretest" only works with dynamic, although that's fixable with a recursive |
|
(Although in "static", that recursive make would actually depend on "static" which would build the whole thing, thereby rendering the smaller build pointless). |
|
This looks good to me. A little ugly, but as long as we get this working more nicely with future EU:MM releases, go for it! |
mohawk2
force-pushed
the
corebuild-improve
branch
from
d0799c8
to
fc32b6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the "core" target doesn't build
MathorMatrixOpsand both are needed. Also, usinggmake -j4, the core SOs are usually (but not always) not built. This fixes or works around these issues.