Make Filter::Util::Call the default engine for PDL::NiceSlice #74
Conversation
This is the original source filter implementation. The more correct one using Filter::Simple is too slow. Work to fix is underway but postponed for PDL-2.009
| ## TODO: Add configuration argument to perldl.conf | ||
| ## $PDL::NiceSlice::engine = $engine_ok{'Filter::Util::Call'}; # default engine type | ||
| $PDL::NiceSlice::engine = $engine_ok{'Filter::Util::Call'}; # default engine type |
There was a problem hiding this comment.
It's a pity this is necessary for now, but evidently it is. We should probably add a test exercising the case in #25 / https://sourceforge.net/p/pdl/bugs/238/
|
It's not 100% clear to me why the Filter::Simple version was so slow (the tests took about 900ms on my machine with that, vs about 220ms with the old one). However, inserting timing outputs showed MatrixOps was loading PDL::NiceSlice. After making that not be the case with 6ae4c0e, the difference went from about +300% to about +10%. Given that the old version was broken with strings (including SQL), POD, and even comments with partial "nice slice" syntax, that is a price entirely worth paying. Therefore I have switched the default to the Filter::Simple with 4a790d9, which finally fixes this problem, and #25 and #32. |
|
The Filter::Simple implementation was in fact very slow on bigger files (such as the 6700-line PDL::LinearAlgebra taking 10s to load). Analysis revealed this was due to a performance bug in Text::Balanced, worked around in PDL with 31b991b and the same change submitted to Text::Balanced itself with steve-m-hay/Text-Balanced#5 |
This is the original source filter implementation. The more
correct one using Filter::Simple is too slow. Work to fix is
underway but postponed for PDL-2.009