Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: opal/opal
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 36bf584bcbb0
Choose a base ref
...
head repository: opal/opal
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a7d15256bdd9
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Mar 12, 2015

  1. Clean up Array#partition bug filter. 

    Pass "Array#partition returns two arrays"
Pass "Array#partition does not return subclass instances on Array subclasses"
FAIL "Array#partition returns in the left array values for which the block evaluates to true"
because of a problem with integer division in Opal (see #748)
E.g. [0, 1, 2, 3, 4, 5].partition { |i| i / 3 == 0 }
Expected: [[0, 1, 2], [3, 4, 5]]
Actual: [[0], [1, 2, 3, 4, 5]]
    @vais
    vais committed Mar 12, 2015
    Copy the full SHA
    47c0501 View commit details

  2. Merge pull request #749 from vais/array 

    Clean up Array#partition bug filter
    @elia
    elia committed Mar 12, 2015
    Copy the full SHA
    a7d1525 View commit details
Showing with 0 additions and 2 deletions.
  1. +0 −2 spec/filters/bugs/array.rb
2 changes: 0 additions & 2 deletions spec/filters/bugs/array.rb
View file
Original file line number Diff line number Diff line change
@@ -182,8 +182,6 @@
fails "Array#hash returns the same fixnum for arrays with the same content"

fails "Array#partition returns in the left array values for which the block evaluates to true"
fails "Array#partition returns two arrays"
fails "Array#partition does not return subclass instances on Array subclasses"

fails "Array#| acts as if using an intermediate hash to collect values"