Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specs for Enumerable#slice_when #3347

Merged
merged 1 commit into from
Mar 7, 2015

Conversation

jsyeo
Copy link
Member

@jsyeo jsyeo commented Mar 6, 2015

😅

@result.to_a.should == [[10, 9], [7, 6], [4, 3, 2, 1]]
end

it "calls the block the length of the receiver enumerable minus one times" do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is "calls the block the length" supposed to mean?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be calls the block for ... times 😖 . I wasn't particularly awake at the time I wrote it. I have fixed it in the latest commit.

@yorickpeterse
Copy link
Contributor

Github is now showing 2 commits with the same message, both (as it appears) modifying the same file. Could you rebase these commits into a single one?

@jsyeo jsyeo force-pushed the slice_when_spec branch from 8954b89 to 1f0ed32 Compare March 7, 2015 14:15
@jsyeo
Copy link
Member Author

jsyeo commented Mar 7, 2015

😕 not sure how that happened. I probably edited the commit message instead of squashing it. Anyway, I've fixed it.

@yorickpeterse
Copy link
Contributor

👍

yorickpeterse pushed a commit that referenced this pull request Mar 7, 2015
Add specs for Enumerable#slice_when
@yorickpeterse yorickpeterse merged commit 92869eb into rubinius:2.2 Mar 7, 2015
@jsyeo jsyeo deleted the slice_when_spec branch March 12, 2015 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants