Minor refactoring to address sonar-related issues #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throws declaration should not be redundant (RuntimeException unneeded in function signature: FcrepoTransactionManager) Class Data Abstraction Coupling (FcrepoClient constructor logic moved into FcrepoHttpClientBuilder class) Class Fan Out Complexity (HttpRequestBase instance creation moved to HttpMethods class) Generic exceptions should never be thrown (FcrepoProducer now throws a TransactionSystemException) Public types should be documented (processor.* classes now have full documentation) String literals should not be duplicated (FcrepoClient debug messages are now more specific) FcrepoTransactionManager thrown exceptions are now more specific
|
Resolved with: e039ef0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://jira.duraspace.org/browse/FCREPO-1397
Throws declaration should not be redundant (RuntimeException unneeded in
function signature: FcrepoTransactionManager)
Class Data Abstraction Coupling (FcrepoClient constructor logic moved
into FcrepoHttpClientBuilder class)
Class Fan Out Complexity (HttpRequestBase instance creation moved to
HttpMethods class)
Generic exceptions should never be thrown (FcrepoProducer now throws a
TransactionSystemException)
Public types should be documented (processor.* classes now have full
documentation)
String literals should not be duplicated (FcrepoClient debug messages
are now more specific)
FcrepoTransactionManager thrown exceptions are now more specific