added x_requested_with method to Mojo::Headers

mojolicious · Jan 30, 2012 · 11819d7 · 11819d7
1 parent a628a33
commit 11819d7
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 7 deletions.
diff --git a/Changes b/Changes
@@ -5,8 +5,8 @@ This file documents the revision history for Perl extension Mojolicious.
         - Added EXPERIMENTAL drain event to Mojo::Transaction::WebSocket.
         - Added EXPERIMENTAL support for RSV1-3 flags to
           Mojo::Transaction::WebSocket.
-        - Added x_forwarded_host and x_forwarded_https methods to
-          Mojo::Headers.
+        - Added x_forwarded_host, x_forwarded_https and x_requested_with
+          methods to Mojo::Headers.
         - Removed experimental status from JSON Pointer support.
         - Added pdf MIME type. (bfaist)
         - Improved documentation.

diff --git a/lib/Mojo/Headers.pm b/lib/Mojo/Headers.pm
@@ -15,7 +15,7 @@ my @HEADERS = (
   qw/Sec-WebSocket-Key Sec-WebSocket-Origin Sec-WebSocket-Protocol/,
   qw/Sec-WebSocket-Version Server Set-Cookie Status Trailer/,
   qw/Transfer-Encoding Upgrade User-Agent WWW-Authenticate X-Forwarded-For/,
-  qw/X-Forwarded-Host X-Forwarded-HTTPS/
+  qw/X-Forwarded-Host X-Forwarded-HTTPS X-Requested-With/
 );
 {
   no strict 'refs';
@@ -609,6 +609,13 @@ Shortcut for the C<X-Forwarded-Host> header.
 
 Shortcut for the C<X-Forwarded-HTTPS> header.
 
+=head2 C<x_requested_with>
+
+  my $x_requested_with = $headers->x_requested_with;
+  $headers             = $headers->x_requested_with('XMLHttpRequest');
+
+Shortcut for the C<X-Requested-With> header.
+
 =head1 SEE ALSO
 
 L<Mojolicious>, L<Mojolicious::Guides>, L<http://mojolicio.us>.

diff --git a/lib/Mojo/Message/Request.pm b/lib/Mojo/Message/Request.pm
@@ -91,9 +91,7 @@ sub is_secure {
   return ($url->scheme || $url->base->scheme || '') eq 'https';
 }
 
-sub is_xhr {
-  (shift->headers->header('X-Requested-With') || '') =~ /XMLHttpRequest/i;
-}
+sub is_xhr { (shift->headers->x_requested_with || '') =~ /XMLHttpRequest/i }
 
 sub param {
   my $self = shift;

diff --git a/t/mojo/headers.t b/t/mojo/headers.t
@@ -1,7 +1,7 @@
 use Mojo::Base -strict;
 
 # "Remember, you can always find East by staring directly at the sun."
-use Test::More tests => 91;
+use Test::More tests => 92;
 
 # "So, have a merry Christmas, a happy Hanukkah, a kwaazy Kwanza,
 #  a tip-top Tet, and a solemn, dignified, Ramadan.
@@ -96,6 +96,7 @@ is $headers->x_forwarded_for('foo')->x_forwarded_for,   'foo', 'right value';
 is $headers->x_forwarded_host('foo')->x_forwarded_host, 'foo', 'right value';
 is $headers->x_forwarded_https('foo')->x_forwarded_https, 'foo',
   'right value';
+is $headers->x_requested_with('foo')->x_requested_with, 'foo', 'right value';
 
 # Clone
 $headers = Mojo::Headers->new;