Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Truffle] Returning nil for out of range Array#delete_at #2701

Merged
merged 1 commit into from Mar 14, 2015

Conversation

bjfish
Copy link
Contributor

@bjfish bjfish commented Mar 14, 2015

Please review because I am not too familiar with contains and branch profile.

Maybe the profiles are not needed here?

@chrisseaton
Copy link
Contributor

Although it may look like the branch profiles are not needed because the code behind them is so simple, they are still doing something important - they are reducing the number of types that a value may be. If the compiler sees both the possibility of nil and say a Fixnum, it will have to handle both types from this point onward. If we put the nil behind a branch profile, the rest of the code can assume it has a Fixnum.

chrisseaton added a commit that referenced this pull request Mar 14, 2015
[Truffle] Returning nil for out of range Array#delete_at
@chrisseaton chrisseaton merged commit b1880ea into jruby:master Mar 14, 2015
@chrisseaton chrisseaton added this to the truffle-dev milestone Mar 14, 2015
@bjfish bjfish deleted the truffle_array_delete_at_nil branch March 14, 2015 13:21
@enebo enebo added this to the Non-Release milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants