Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: 00e4357a6179
Choose a base ref
...
head repository: jruby/jruby
compare: d45a1c896819
Choose a head ref
  • 6 commits
  • 4 files changed
  • 1 contributor

Commits on Mar 11, 2015

  1. simplify RubyBasicObject's "generic" toJava method internal (unwrap g… 

    …etValue once)
    @kares
    kares committed Mar 11, 2015
    Copy the full SHA
    142fce8 View commit details
    Browse the repository at this point in the history

  2. tune ArrayProxy - allow indexing by Java Integer wrappers (inspired by … 

    …#2658)

avoids "ugly-sh" failures such as :

TypeError: wrong argument type Java::JavaLang::Integer (expected Range)
    org/jruby/java/proxies/ArrayJavaProxy.java:81:in `[]'
    @kares
    kares committed Mar 11, 2015
    Copy the full SHA
    3f4bb5f View commit details
    Browse the repository at this point in the history

  3. ArrayUtils cleanup + remove unnecessary cast

    @kares
    kares committed Mar 11, 2015
    Copy the full SHA
    c4e0a68 View commit details
    Browse the repository at this point in the history

  4. share ArrayProxy's array index conversion code (between [] and []=) +… 

    … review internals

... also added a test for new `[]` and `[]=` index conversion (inspired by #2658)
    @kares
    kares committed Mar 11, 2015
    Copy the full SHA
    9cb1fac View commit details
    Browse the repository at this point in the history

  5. Java array proxy wrapper's at works with int-like objects due conve… 

    …rtToInteger
    @kares
    kares committed Mar 11, 2015
    Copy the full SHA
    5779228 View commit details
    Browse the repository at this point in the history

  6. use the same Java array java proxy index conversion (between at and… 

    … `[]`)
    @kares
    kares committed Mar 11, 2015
    Copy the full SHA
    d45a1c8 View commit details
    Browse the repository at this point in the history