Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail on Sparql update for subjects outside repository domain #747

Closed
wants to merge 4 commits into from

Conversation

whikloj
Copy link
Collaborator

@whikloj whikloj commented Mar 12, 2015

Addresses FCREPO-1361

@ajs6f
Copy link
Contributor

ajs6f commented Mar 12, 2015

Because you're PRing from your repo and not from origin, I can't make line comments, but if I could, I would suggest logging the exception before throwing it. This is so that in debugging situations, it's clear where the problem happened. Remember that exceptions thrown out of that listener don't actually get reported out until quite a ways downstream.

Fix trailing whitespace
@whikloj
Copy link
Collaborator Author

whikloj commented Mar 12, 2015

Gah. Sorry about that, I was confused as you had commented inline to my changes to the ontology repo, but the restrictions on it maybe different. I have added in some debug statements.

@ajs6f
Copy link
Contributor

ajs6f commented Mar 12, 2015

No prob-- it's because I don't have write access to your clone of fcrepo4. Not to be a picky person, but maybe ERROR is more appropriate for this than DEBUG?

@awoods
Copy link

awoods commented Mar 13, 2015

Resolved with: 2e5265c

@awoods awoods closed this Mar 13, 2015
@whikloj whikloj deleted the FCREPO-1361 branch October 22, 2016 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants