Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pt_BR.lang #923

Closed
wants to merge 1 commit into from
Closed

Create pt_BR.lang #923

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 18, 2015

No description provided.

@fnuecke
Copy link
Member

fnuecke commented Mar 9, 2015

Thanks. Do you plan on completing the translation (e.g. the tooltips) or should I merge this as-is?

@ghost
Copy link
Author

ghost commented Mar 11, 2015

Sorry, unfortunately I have no time to finish the translation and review it ingame.
I'm working 15 hours a day and lately I don't have much spare time to Minecraft.
[]s

Sorry, something went wrong.

@LordFokas
Copy link
Contributor

It bothers me a bit that Sangar is credited for the creation of the pt_PT file in the pt_BR one, given I am the author (although sangar committed a lot of small changes to it). It also confuses me, why doesn't my commit show up the pt_PT's history? A git server is not the kind of thing that forgets were stuff came from.

I should also fix the pt-PT file, when I have the time. It just happens I often don't, and when I do patching lang files isn't the first thing that comes to my mind :(

Also, if someone could put the original en_US key/value pairs that are missing in the pt_PT file, it would ease my life a lot in terms of attempting to translate it, which would also ease @al-myr's life patching the pt_BR one as he could simply pull stuff from pt_PT instead of checking for missing entries.

Sorry, something went wrong.

@fnuecke
Copy link
Member

fnuecke commented Mar 12, 2015

@LordFokas The reason it doesn't show up seems to be that Github doesn't track that info across file moves/renames. If you look at the history starting at the commit before the rename (which was for gradle, I so do not miss the old days) all is as it should be.

Sorry, something went wrong.

@fnuecke
Copy link
Member

fnuecke commented Apr 6, 2015

Closing this due to inactivity.
If someone wants to finish this, please create a new PR with the updated files, thanks.

@fnuecke fnuecke closed this Apr 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants