descriptive warning when using the eq overloaded operator on non-numeric strings #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmughal
force-pushed
the
pdl-eq-with-string-warning
branch
from
2d25c52
to
5abf334
Compare
wchristian
force-pushed
the
pdl-eq-with-string-warning
branch
from
5abf334
to
13f11e7
Compare
|
This looks good to me: I second it. |
…ric strings Instead of saying "isn't numeric in null operation", provide a more descriptive warning that indicates the value and the operator being used. See <http://sourceforge.net/p/pdl/bugs/332>, <#33> for more information.
zmughal
force-pushed
the
pdl-eq-with-string-warning
branch
from
13f11e7
to
4b77820
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of saying "isn't numeric in null operation", provide a more
descriptive warning that indicates the value and the operator being
used.
See http://sourceforge.net/p/pdl/bugs/332,
#33 for more information.