Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved Trunk3010 #280

Closed
wants to merge 2 commits into from
Closed

Solved Trunk3010 #280

wants to merge 2 commits into from

Conversation

apremalal
Copy link

URL : https://tickets.openmrs.org/browse/TRUNK-3010

Redirected the user to findpatientpage with a message telling ,there is no patient with the patient id..

Any feedback will be greatly appriciated !

@dkayiwa
Copy link
Member

dkayiwa commented Apr 22, 2013

Are you using the OpenMRS formatter as at? https://wiki.openmrs.org/display/docs/Coding+Conventions
In other-wards, is it possible for you to commit only what you actually changed? :)

@apremalal
Copy link
Author

Thank you for reviewing the pull request.I've created a new pull request with the changes. #285

@dkayiwa
Copy link
Member

dkayiwa commented Apr 26, 2013

Can you comment on the ticket that you have created a new pull request? Remember to also include the pull request url on the ticket. :)

@apremalal
Copy link
Author

I've already did that :)

@wluyima
Copy link
Member

wluyima commented Jun 12, 2013

Closing this pull request since it was replaced by #285.
Premalal, FYI, as long you commit to the same branch from which you issued the initial pull request, github will automatically merge the changes into the original pull request, so you need to create a new one.

@wluyima wluyima closed this Jun 12, 2013
RandilaP pushed a commit to RandilaP/openmrs-core that referenced this pull request Jul 31, 2023
…mrs#280)

* Added emphasis that esm-template can be used to create a new MF

* Update docs/main/creating_a_microfrontend.md

* Update docs/main/creating_a_microfrontend.md

* Update docs/main/creating_a_microfrontend.md

Co-authored-by: Brandon Istenes <bistenes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants