Item13295: Don't override Oops errors during save

If a beforeSaveHandler thows an OopsException, UI::Save was intercepting it and replacing it with a less informative Oops message. Propagate OopsExceptions rather than replacing them.
foswiki · Mar 7, 2015 · 9c83764 · 9c83764
1 parent f07586a
commit 9c83764
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/core/lib/Foswiki/UI/Save.pm b/core/lib/Foswiki/UI/Save.pm
@@ -653,6 +653,9 @@ WARN
     try {
         $topicObject->save(%$saveOpts);
     }
+    catch Foswiki::OopsException with {
+        shift->throw();    # propagate
+    }
     catch Error with {
         throw Foswiki::OopsException(
             'attention',
@@ -674,6 +677,9 @@ WARN
             try {
                 $a->{tom}->copyAttachment( $a->{name}, $topicObject );
             }
+            catch Foswiki::OopsException with {
+                shift->throw();    # propagate
+            }
             catch Error with {
                 throw Foswiki::OopsException(
                     'attention',