This repository has been archived by the owner on Jan 3, 2019. It is now read-only.
Implementation for no binary content jcr/xml file system persistence. #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -38,11 +38,17 @@ | |||
| </bean> | |||
| <!-- Solr Indexer END--> | |||
|
|
|||
| <!-- jcr/xml persistence Indexer --> | |||
| <bean id="jcrXmlPersist" class="org.fcrepo.indexer.persistence.JcrXmlPersistenceIndexer"> | |||
| <property name="path" value="${jcr.persist.dir:./target/test-classes/jcrXml/}"/> | |||
There was a problem hiding this comment.
Create a default value that is more suitable for production use (${java.io.tmpdir}?)
There was a problem hiding this comment.
How about ${java.io.dir}? The persisted jcr/xml looks more like permanent storage compared to "tmp".
There was a problem hiding this comment.
My point is that we want a reasonable default value, and "./target/test-classes/jcrXml" does not seem like a reasonable default value.
Maybe: "jcrXml-storage" or the java tmp dir.
configuring file path as suggested.
|
Okay, see lsitu@bb1f5eb. |
| * @author ajs6f | ||
| * @date Aug 19, 2013 | ||
| */ | ||
| public class JcrXmlPesistenceIndexerTest { |
There was a problem hiding this comment.
Fix typo:
JcrXmlPesistenceIndexerTest should be "JcrXmlPersistenceIndexerTest"
system persistence.
|
Corrected at commit lsitu@e8894a6. |
|
Resolved with: b78416a Addresses: https://www.pivotaltracker.com/story/show/74702010 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/s/projects/684825/stories/74702010
We should be able to persist jcr/xml with no binary contents to the file system now. The location can be configured with parameter jcr.persist.dir as defined in in fcrepo-jms-indexer-webapp/src/main/resources/spring/indexer-core.xml, and the filename for the jcr/xml will be {id}-jcr.xml.