Fix for string parsing and dimension handling (fixes SF#367) #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a logic error where ->setdims([]) would get called when trying to remove the outermost dimension, but this would run after using clump() on a string that had a single value and ->dims() == 1. This also fixes the BAD value parsing bug in SF#367 which led to an incorrect BAD value when parsing the string "[BAD]". See <http://sourceforge.net/p/pdl/bugs/367/>, <#47>.
zmughal
force-pushed
the
fix-bad-value-string-parsing
branch
from
95346c8
to
9585de3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a logic error where
->setdims([])would get called when tryingto remove the outermost dimension, but this would run after using
clump()on a string that had a single value and->dims() == 1.This also fixes the BAD value parsing bug in SF#367 which led to an
incorrect BAD value when parsing the string "[BAD]".
See http://sourceforge.net/p/pdl/bugs/367/,
#47.