Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move RubyDate and joda-time into "extension" gem #2691

Closed
mkristian opened this issue Mar 13, 2015 · 3 comments
Closed

move RubyDate and joda-time into "extension" gem #2691

mkristian opened this issue Mar 13, 2015 · 3 comments
Milestone
Won't Fix

Comments

@mkristian
Copy link
Member

a brief look into the code looks like it is possible to move all the code which uses joda-time into a gem which we can use in the same manner as jruby-readline.

advantage:

  • you can decide on the joda-time version via jar-dependencies or jbundler or manually. so your required java libraries can decide which joda-time version to use without fiddling with classpath of jruby itself (kind of difficult with rvm and rbenv)
  • reversing classloader.delegate will not produce errors regarding joda-time since all joda classes used by jruby living inside jrubyclassloader

disadvantage:

  • extra gem

this is just an attempt to improve usefulness of this classloader.delegate and improve the overall classloader setup. other places are
@mkristian mkristian changed the title move RubyDate and friends and joda-time into "extension" move RubyDate and joda-time into "extension" Mar 13, 2015
@mkristian mkristian changed the title move RubyDate and joda-time into "extension" move RubyDate and joda-time into "extension" gem Mar 17, 2015
@nirvdrum
Copy link
Contributor

Allowing arbitrary versions of joda to be used sounds like a bad idea. We can't make any guarantees about compatibility with versions other than the one we support and I'd hate to see our support policy broaden to whatever version of joda. If there's a classpath conflict, I suggest we shade joda and rename the package.

@mkristian
Copy link
Member Author

mkristian commented Apr 17, 2015 via email

@kares
Copy link
Member

kares commented Mar 1, 2018

with 9.2 only supporting Java 8 we could have been moving towards getting rid of joda-time.
of course due it being part of the API its not as simple.
am hoping providing Java 8 alternatives in the APIs such as RubyTime (and maybe doing deprecations).
anyway, I believe this issue is now pretty much defunct ...

@kares kares closed this as completed Mar 1, 2018
@kares kares added this to the Won't Fix milestone Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Won't Fix
Development

No branches or pull requests
3 participants
@nirvdrum @mkristian @kares