Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: opal/opal
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a7d15256bdd9
Choose a base ref
...
head repository: opal/opal
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2093db494c16
Choose a head ref
  • 3 commits
  • 2 files changed
  • 2 contributors

Commits on Mar 12, 2015

  1. String#===, String#==, and String#eql? fully compliant with rubyspec

    @vais
    vais committed Mar 12, 2015
    Copy the full SHA
    c7bea09 View commit details

Commits on Mar 13, 2015

  1. Update spec/corelib submodule to make String#===, String#==, and Stri… 

    …ng#eql? fully compliant with rubyspec
    @vais
    vais committed Mar 13, 2015
    Copy the full SHA
    00da096 View commit details

  2. Merge pull request #751 from vais/string_not_supported 

    Update spec/corelib submodule to make String#===, String#==, and String#eql? fully compliant with rubyspec
    @elia
    elia committed Mar 13, 2015
    Copy the full SHA
    2093db4 View commit details
Showing with 1 addition and 6 deletions.
  1. +1 −1 spec/corelib
  2. +0 −5 spec/filters/bugs/string.rb
2 changes: 1 addition & 1 deletion spec/corelib
Submodule corelib updated from c4e322 to 7b9a03
5 changes: 0 additions & 5 deletions spec/filters/bugs/string.rb
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
opal_filter "String" do
fails "String#=== returns false if obj does not respond to to_str" #passes except for the line with symbol: fails "'hello'.send(@method, :hello).should be_false"

fails "String#=~ raises a TypeError if a obj is a string"

fails "String#[] with Range calls to_int on range arguments"
@@ -213,9 +211,6 @@
fails "String#each_byte keeps iterating from the old position (to new string end) when self changes"
fails "String#each_byte passes each byte in self to the given block"

fails "String#== returns false if obj does not respond to to_str" #passes except for the line with symbol: fails "'hello'.send(@method, :hello).should be_false"
fails "String#eql? when given a non-String returns false" #passes except for the line with symbol: fails "'hello'.should_not eql(:hello)"

fails "String#hex treats leading characters of self as a string of hex digits"

fails "String#initialize with an argument raises a RuntimeError on a frozen instance when self-replacing"