Skip to content

source maps fix #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 23, 2015
Merged

source maps fix #40

merged 8 commits into from
Mar 23, 2015

Conversation

elia
Copy link
Member

@elia elia commented Mar 13, 2015

related opal PR is opal/opal#722

This should fix most 404 and 500 problems

@cantonic
Copy link
Contributor

Yay, it's working! Thx for all the effort.

There is just one thing: I keep getting Opal already loaded. Loading twice can cause troubles, please fix your setup. from /__OPAL_SOURCE_MAPS__/jquery_ujs.js in the js console.

@cantonic
Copy link
Contributor

and a minor thing i noticed: for testing this I have added a failing line in app/assets/javascripts/drive/directories.js.rb:5, but the js console shows kernel.rb as the source file. It is ok, since I can expand the error message and click on directories.rb, but I wondered: is it supposed to be like this?

Also I added puts 'foo' to directories.js.rb, but in the js console main.rb is displayed as the source file.

My console output:
screen shot 2015-03-13 at 22 38 46

@elia
Copy link
Member Author

elia commented Mar 13, 2015

@cantonic that's by design, everything is flattened to .rb, this makes it easier to serve stuff from the source maps server. Even if not optimal it makes the system more reliable.

@cantonic
Copy link
Contributor

Ah okay, thx for the explanation.

@elia elia merged commit 0fc5cee into master Mar 23, 2015
@elia elia deleted the elia/source-maps-fix branch March 23, 2015 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants