Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple fixes for type warnings and use better HTTP machinery #152

Closed
wants to merge 4 commits into from
Closed

Simple fixes for type warnings and use better HTTP machinery #152

wants to merge 4 commits into from

Conversation

ajs6f
Copy link
Contributor

@ajs6f ajs6f commented Nov 14, 2013

https://www.pivotaltracker.com/story/show/60810250

Just a few minor emendations to places where warnings were unneeded.

@ghost ghost assigned awoods Nov 14, 2013
@cbeer
Copy link
Contributor

cbeer commented Dec 12, 2013

I tried to rebase this onto master, but the tests end up hanging for me. Can you give it a try?

@ajs6f
Copy link
Contributor Author

ajs6f commented Dec 13, 2013

Yeah, I think I might know what that might be. Maybe. Possibly.

@ajs6f
Copy link
Contributor Author

ajs6f commented Dec 13, 2013

@cbeer Which tests were hanging?

@ajs6f ajs6f closed this Dec 13, 2013
@ajs6f ajs6f mentioned this pull request Dec 13, 2013
Merged
@cbeer cbeer deleted the KillWarnings branch December 13, 2013 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@awoods awoods

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajs6f @cbeer @awoods