Add strict and warnings

Conflicts: CHANGELOG
PerlGameDev · Mar 14, 2015 · a7e56d5 · a7e56d5
1 parent 70134b6
commit a7e56d5
Show file tree

Hide file tree

Showing 35 changed files with 45 additions and 1 deletion.
diff --git a/lib/SDL/Constants.pm b/lib/SDL/Constants.pm
@@ -1,6 +1,7 @@
 #!/usr/bin/env perl
 package SDL::Constants;
 
+use strict;
 use warnings;
 use base 'Exporter';
 use Config;

diff --git a/lib/SDL_perl.pm b/lib/SDL_perl.pm
@@ -30,7 +30,10 @@
 
 package SDL_perl;
 
-@ISA = qw/ DynaLoader /;
+use strict;
+use warnings;
+
+our @ISA = qw/ DynaLoader /;
 require DynaLoader;
 
 use SDL::Internal::Loader;

diff --git a/lib/SDLx/Music/Data.pm b/lib/SDLx/Music/Data.pm
@@ -1,5 +1,8 @@
 package SDLx::Music::Data;
 
+use strict;
+use warnings;
+
 sub volume
 {
 	$_[0]->{volume} = $_[1] if $_[1];

diff --git a/t/config.t b/t/config.t
@@ -1,5 +1,7 @@
 # t/002_config.t - test config() functionality
 
+use strict;
+use warnings;
 use Test::More tests => 2;
 
 BEGIN { use_ok('SDL::Config'); }

diff --git a/t/core.t b/t/core.t
@@ -1,5 +1,6 @@
 #!/usr/bin/perl -w
 use strict;
+use warnings;
 use Config;
 
 use SDL;

diff --git a/t/core_audio.t b/t/core_audio.t
@@ -7,6 +7,7 @@ BEGIN { # http://wiki.cpantesters.org/wiki/CPANAuthorNotes
 	}
 }
 use strict;
+use warnings;
 use SDL;
 use SDL::Audio;
 use SDL::AudioSpec;

diff --git a/t/core_audiospec.t b/t/core_audiospec.t
@@ -7,6 +7,7 @@ BEGIN { # http://wiki.cpantesters.org/wiki/CPANAuthorNotes
 	}
 }
 use strict;
+use warnings;
 use threads;
 use threads::shared;
 use SDL;

diff --git a/t/core_cd.t b/t/core_cd.t
@@ -1,5 +1,6 @@
 #!/usr/bin/perl -w
 use strict;
+use warnings;
 use SDL;
 
 BEGIN {

diff --git a/t/core_events.t b/t/core_events.t
@@ -1,5 +1,6 @@
 #!/usr/bin/perl -w
 use strict;
+use warnings;
 use SDL;
 use SDL::Event;
 use SDL::Events;

diff --git a/t/core_joystick.t b/t/core_joystick.t
@@ -1,5 +1,6 @@
 #!/usr/bin/perl -w
 use strict;
+use warnings;
 use SDL;
 use Test::More;
 use SDL::Joystick;

diff --git a/t/core_mouse.t b/t/core_mouse.t
@@ -1,5 +1,6 @@
 #!/usr/bin/perl -w
 use strict;
+use warnings;
 use SDL;
 use Test::More;
 use SDL::Mouse;

diff --git a/t/core_multi.t b/t/core_multi.t
@@ -1,5 +1,6 @@
 #!/usr/bin/perl -w
 use strict;
+use warnings;
 use SDL;
 use Test::More;
 

diff --git a/t/core_rwops.t b/t/core_rwops.t
@@ -1,5 +1,6 @@
 #!/usr/bin/perl -w
 use strict;
+use warnings;
 use SDL;
 use Test::More;
 use SDL::RWOps;

diff --git a/t/core_surface.t b/t/core_surface.t
@@ -9,6 +9,7 @@ BEGIN {
 }
 
 use strict;
+use warnings;
 use SDL;
 use SDL::Config;
 use SDL::Surface;

diff --git a/t/core_timer.t b/t/core_timer.t
@@ -9,6 +9,7 @@ BEGIN { # http://wiki.cpantesters.org/wiki/CPANAuthorNotes
 use threads;
 use threads::shared;
 use strict;
+use warnings;
 use SDL;
 use Test::More;
 use SDL::Time;

diff --git a/t/core_version.t b/t/core_version.t
@@ -1,5 +1,6 @@
 #!/usr/bin/perl -w
 use strict;
+use warnings;
 use SDL;
 use SDL::Version;
 use Test::More tests => 8;

diff --git a/t/core_video.t b/t/core_video.t
@@ -1,5 +1,6 @@
 #!/usr/bin/perl -w
 use strict;
+use warnings;
 use SDL;
 use SDL::Color;
 use SDL::Surface;

diff --git a/t/core_video_convert_surface.t b/t/core_video_convert_surface.t
@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use SDL;
 use SDL::Rect;
 use SDL::Color;

diff --git a/t/core_video_gamma.t b/t/core_video_gamma.t
@@ -1,5 +1,6 @@
 #!/usr/bin/perl -w
 use strict;
+use warnings;
 use SDL;
 use SDL::Color;
 use SDL::Surface;

diff --git a/t/extendingrect.t b/t/extendingrect.t
@@ -1,4 +1,6 @@
 package MyRect;
+use strict;
+use warnings;
 use base 'SDL::Rect';
 
 sub new {

diff --git a/t/image.t b/t/image.t
@@ -1,5 +1,6 @@
 #!/usr/bin/perl -w
 use strict;
+use warnings;
 use SDL;
 use SDL::Config;
 use SDL::Version;

diff --git a/t/image_xpm_array.t b/t/image_xpm_array.t
@@ -1,6 +1,8 @@
 #!/usr/bin/perl -Iblib/lib -Iblib -Iblib/arch
 #
 
+use strict;
+use warnings;
 use SDL;
 use SDL::Config;
 use SDL::Rect;

diff --git a/t/mixer.t b/t/mixer.t
@@ -1,5 +1,6 @@
 #!/usr/bin/perl -w
 use strict;
+use warnings;
 use SDL;
 use SDL::Config;
 

diff --git a/t/mixer_groups.t b/t/mixer_groups.t
@@ -1,5 +1,6 @@
 #!/usr/bin/perl -w
 use strict;
+use warnings;
 use SDL;
 use SDL::Config;
 

diff --git a/t/mixer_mixmusic.t b/t/mixer_mixmusic.t
@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use SDL;
 use SDL::Config;
 

diff --git a/t/mixer_music.t b/t/mixer_music.t
@@ -1,5 +1,6 @@
 #!/usr/bin/perl -w
 use strict;
+use warnings;
 
 my $audiodriver;
 

diff --git a/t/mixer_samples.t b/t/mixer_samples.t
@@ -1,5 +1,6 @@
 #!/usr/bin/perl -w
 use strict;
+use warnings;
 use SDL;
 use SDL::Config;
 

diff --git a/t/pango.t b/t/pango.t
@@ -1,5 +1,6 @@
 #!/usr/bin/perl -w
 use strict;
+use warnings;
 use SDL;
 use SDL::Config;
 use SDL::Color;

diff --git a/t/sdlgamerect.t b/t/sdlgamerect.t
@@ -1,5 +1,6 @@
 use Test::More tests => 87;
 use strict;
+use warnings;
 use SDL;
 
 use_ok('SDLx::Rect');

diff --git a/t/sdlx_app.t b/t/sdlx_app.t
@@ -2,6 +2,7 @@
 
 # basic testing of SDLx::App
 use strict;
+use warnings;
 use SDL;
 use SDL::Config;
 use SDL::Rect;

diff --git a/t/sdlx_sound.t b/t/sdlx_sound.t
@@ -1,5 +1,8 @@
 # basic testing of SDLx::Sound
 
+use strict;
+use warnings;
+
 my $audiodriver;
 
 BEGIN {

diff --git a/t/sdlx_text.t b/t/sdlx_text.t
@@ -1,4 +1,5 @@
 use strict;
+use warnings;
 use SDL;
 use SDL::Config;
 use SDL::Color;

diff --git a/t/smpeg.t b/t/smpeg.t
@@ -6,6 +6,7 @@ BEGIN {
 }
 
 use strict;
+use warnings;
 use SDL;
 use SDL::Config;
 

diff --git a/t/ttf.t b/t/ttf.t
@@ -1,5 +1,6 @@
 #!/usr/bin/perl -w
 use strict;
+use warnings;
 use SDL;
 use SDL::Config;
 use SDL::Color;

diff --git a/t/ttf_font.t b/t/ttf_font.t
@@ -1,5 +1,6 @@
 #!/usr/bin/perl -w
 use strict;
+use warnings;
 use SDL;
 use SDL::Config;