[Truffle] Refactoring Array#+ to handle more cases and adding #to_ary #2702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisseaton
added a commit
that referenced
this pull request
Mar 14, 2015
[Truffle] Refactoring Array#+ to handle more cases and adding #to_ary
|
@chrisseaton did these specialization changes look alright? Thanks. |
|
@bjfish here's a list of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started to refactor this because I got the following error when adding #to_ary:
https://gist.github.com/bjfish/5c6e32592ecb1715a5fd
Please review.
Did I remove any specializations that were need?
Any other updates I should make here right now?