Surgical multi-relationship removal - Addresses FCREPO-1362 #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Check each value of multi value in a reference or weak reference Property when deleting a node, remove only the node being deleted. ** Node comparison incorrect **
| @@ -257,7 +260,22 @@ public void delete() { | |||
| final Iterator<Property> inboundProperties = Iterators.concat(references, weakReferences); | |||
|
|
|||
| while (inboundProperties.hasNext()) { | |||
| inboundProperties.next().remove(); | |||
| final Property prop = inboundProperties.next(); | |||
| final List<Value> newVals = new ArrayList<Value>(); | |||
There was a problem hiding this comment.
Use the diamond operator: new ArrayList<>().
Update FedoraResourceImplIT to demonstrate the fix in this PR.
|
Resolved with: 4a77e57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: FCREPO-1362