Fix exponential expansion of work in method lookup #2218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enebo
added a commit
that referenced
this pull request
Nov 19, 2014
Fix exponential expansion of work in method lookup
|
as long as the tests pass this will be fine for the current prepend. This code should have been recurring anyway due to the linear nature of inheritance right now. This recursion was needed for the other version of prepend. I hadn't trimmed it because it should have been inert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2217. I'm not quite sure I grok the whole setup here (particularly with respect to the prepend work being done), but it fixes the issue nicely and returns method lookup to linear time.
There are module failures in the test suite, but they were introduced in 98fa7a6.