Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pagedown extra plugin #27

Merged
merged 9 commits into from Jul 23, 2014
Merged

Conversation

keedi
Copy link
Contributor

@keedi keedi commented May 16, 2014

This pull-request contains following:

  • Update latest pagedown library
  • Add latest pagedown-extra library
  • Small patch pagedown-extra for highlighter.js
  • Suggest default setting for pagedown-extra (ex. table class & highligter)
  • Add sample page to explain pagedown-extra features and setting

But I didn't add js and css of highlighter.js or google prettify into statc directory since I can't convince it's right or not. :)

@jberger
Copy link
Owner

jberger commented May 17, 2014

Yikes, this is a lot to look at. I hope to get a chance this weekend, but I also need to prepare my Mojoconf talk

@keedi
Copy link
Contributor Author

keedi commented May 18, 2014

@jberger It's not an urgent issue at all, nevermind. :)

@keedi
Copy link
Contributor Author

keedi commented May 18, 2014

After this patch is applied then load following js/css:

<link rel="stylesheet" href="http://yandex.st/highlightjs/8.0/styles/default.min.css">
<script src="http://yandex.st/highlightjs/8.0/highlight.min.js"></script>
<script> (fuction () { hljs.initHighlightingOnLoad(); })(); </script>

will make Galileo look like:

syntax 2014-05-18 23-04-16

@jberger jberger merged commit 7cc6c78 into jberger:master Jul 23, 2014
@jberger
Copy link
Owner

jberger commented Jul 23, 2014

Sorry it took me so long to evaluate this. I'm not quite sure when I will roll the next release, but this will be in it.

One thought I have had is that there are getting to be too many JSON structures in the setup, I have opened #28 to track improving that.

Thanks again!

@jberger
Copy link
Owner

jberger commented Aug 16, 2014

@keedi I have released 0.035 with this included. Thanks again!

@keedi
Copy link
Contributor Author

keedi commented Aug 19, 2014

Awesome, thank you so much! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants