-
Notifications
You must be signed in to change notification settings - Fork 605
Comparing changes
Open a pull request
base repository: rubinius/rubinius
base: ac5f92af7c86
head repository: rubinius/rubinius
compare: 64d73f9bd5fb
Commits on Mar 12, 2015
-
Creates enumeratorized shared specs.
The enumerable_enumeratorized shared specs are to be used by the Enumerable spec while the enumeratorized shared specs are to be used by Enumerable implementations. The shared specs cover the following cases: * The resulting enumerator size returns the enumerable size (collect, find_all, etc...) * The resulting enumerator size returns nil (find_index, take_while, etc...) * The cycle method (Array as it's own implementation) The enumerable specific tests add tests for the case where the enumerable doesn't have the size method.
Configuration menu - View commit details
-
Copy full SHA for ec7bd05 - Browse repository at this point
Copy the full SHA ec7bd05View commit details -
Extra arg validation tests on each_cons/each_slice
The tests check if ArgumentError is raised also when no block is given, complying with MRI.
Configuration menu - View commit details
-
Copy full SHA for b01d96f - Browse repository at this point
Copy the full SHA b01d96fView commit details -
New Enumerator/Enumerable size calculation tests
It also removes the old falling tests tags.
Configuration menu - View commit details
-
Copy full SHA for 2dd66e4 - Browse repository at this point
Copy the full SHA 2dd66e4View commit details -
Update Enumerable#size when returning Enumerator
Moves Enumerable#each_cons and Enumerable#each_slice argument validation to be done before checking if there's no block given. It creates the EnumerableHelper module to implement the cycle_size 'function' calculation. It avoids 'polluting' the Enumerable module and also allows the cycle_size function to be used on Array.
Configuration menu - View commit details
-
Copy full SHA for f36b84d - Browse repository at this point
Copy the full SHA f36b84dView commit details -
New Enumerator#size tests for the Array class.
It also removes the old falling tests tags.
Configuration menu - View commit details
-
Copy full SHA for 3fb3933 - Browse repository at this point
Copy the full SHA 3fb3933View commit details -
Updated Array#size when returning an Enumerator
It uses the array mirror to implement the helper methods needed for the more complex calculations to avoid 'polluting' the Array class.
Configuration menu - View commit details
-
Copy full SHA for 6eddafb - Browse repository at this point
Copy the full SHA 6eddafbView commit details -
Enumerator#size calculation specs for Hash
These are specs for methods that return an Enumerator instance.
Configuration menu - View commit details
-
Copy full SHA for 1170e4e - Browse repository at this point
Copy the full SHA 1170e4eView commit details -
Update Enumerator#size calculation for Hash
These are specs for methods that return an Enumerator instance.
Configuration menu - View commit details
-
Copy full SHA for 28539a6 - Browse repository at this point
Copy the full SHA 28539a6View commit details -
Enumerator#size calculation specs for Range
These are specs for methods that return an Enumerator instance.
Configuration menu - View commit details
-
Copy full SHA for e99ab4c - Browse repository at this point
Copy the full SHA e99ab4cView commit details -
Update Enumerator#size calculation for Range
These are changes for methods that return an Enumerator instance. It creates the range mirror to implement the helper methods needed for the more complex calculations to avoid 'polluting' the Range class.
Configuration menu - View commit details
-
Copy full SHA for 525277e - Browse repository at this point
Copy the full SHA 525277eView commit details -
Update Enumerator#size specs for Integer
These are specs for methods that return an Enumerator instance.
Configuration menu - View commit details
-
Copy full SHA for 1db7053 - Browse repository at this point
Copy the full SHA 1db7053View commit details -
Update Enumerator#size for Integer
These are changes for methods that return an Enumerator instance.
Configuration menu - View commit details
-
Copy full SHA for defb1a4 - Browse repository at this point
Copy the full SHA defb1a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8314546 - Browse repository at this point
Copy the full SHA 8314546View commit details -
Configuration menu - View commit details
-
Copy full SHA for f4323e3 - Browse repository at this point
Copy the full SHA f4323e3View commit details -
Update specs for Numeric#step with a block
This updates specs for Numeric#step when a block is given and the step is not Numeric. The exception raised in this situation has changed on MRI 2.1.0 from TypeError to ArgumentError.
Configuration menu - View commit details
-
Copy full SHA for c193494 - Browse repository at this point
Copy the full SHA c193494View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4617886 - Browse repository at this point
Copy the full SHA 4617886View commit details -
Update Enumerator#size for Numeric#step.
It creates a numeric mirror class to implement the helper methods needed for the step size calculation to avoid 'polluting' the Numeric class. It also updates the Numeric#step exception used when a block is given and step is not Numeric to ArgumentError to comply with the specs.
Configuration menu - View commit details
-
Copy full SHA for 9ee5aa2 - Browse repository at this point
Copy the full SHA 9ee5aa2View commit details -
Updated Enumerator#size specs for String
These are specs for methods that return an Enumerator instance.
Configuration menu - View commit details
-
Copy full SHA for 633d9c4 - Browse repository at this point
Copy the full SHA 633d9c4View commit details -
Update Enumerator#size for String
These are changes for methods that return an Enumerator instance.
Configuration menu - View commit details
-
Copy full SHA for 6c5c5c6 - Browse repository at this point
Copy the full SHA 6c5c5c6View commit details -
Specs for Enumerator#size for ARGF
These are specs for methods that return a Enumerator instance.
Configuration menu - View commit details
-
Copy full SHA for 85b4dc2 - Browse repository at this point
Copy the full SHA 85b4dc2View commit details -
Specs for Enumerator#size for Dir
These are specs for methods that return an Enumerator instance.
Configuration menu - View commit details
-
Copy full SHA for a384101 - Browse repository at this point
Copy the full SHA a384101View commit details -
These are specs for methods that return an Enumerator instance.
Configuration menu - View commit details
-
Copy full SHA for ff761aa - Browse repository at this point
Copy the full SHA ff761aaView commit details -
Update Enumerator#size for ENV
These are changes for methods that return an Enumerator instance.
Configuration menu - View commit details
-
Copy full SHA for c6a363b - Browse repository at this point
Copy the full SHA c6a363bView commit details -
These are specs for methods that return an Enumerator.
Configuration menu - View commit details
-
Copy full SHA for fbb9bd4 - Browse repository at this point
Copy the full SHA fbb9bd4View commit details -
Enumerator#size specs for Struct
These are specs for methods that return an Enumerator instance.
Configuration menu - View commit details
-
Copy full SHA for acc7a85 - Browse repository at this point
Copy the full SHA acc7a85View commit details -
Update Enumerator#size for Struct
These are changes for methods that return an Enumerator instance.
Configuration menu - View commit details
-
Copy full SHA for 68d2e23 - Browse repository at this point
Copy the full SHA 68d2e23View commit details -
Enumerator#size specs for Enumerator
These are specs for methods that return an Enumerator instance.
Configuration menu - View commit details
-
Copy full SHA for 67b41f3 - Browse repository at this point
Copy the full SHA 67b41f3View commit details -
Update Enumerator#size for Enumerator
These are changes for methods that return an Enumerator instance.
Configuration menu - View commit details
-
Copy full SHA for 64d73f9 - Browse repository at this point
Copy the full SHA 64d73f9View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff ac5f92af7c86...64d73f9bd5fb