Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: eb291de00e6e
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 808a968409b6
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Oct 24, 2013

  1. build: fix test-gc weakref build rule

    Make the build rule depend on the build artifact (weakref.node) itself
    rather than the directory it's built in.  Depending on the directory
    means that a build failure won't trigger a rebuild on the next
    invocation because the directory's timestamp has been updated.
    
    This is a back-port of commit 1189571 from the master branch that
    hopefully fixes the following CI error:
    
        executing:  make test/gc/node_modules/weak/build/
        make: *** No rule to make target `test/gc/node_modules/weak/build/'.
        Command exited with non-zero: make test/gc/node_modules/weak/build/
        Build step 'Execute NodeJS script' marked build as failure
    bnoordhuis committed Oct 24, 2013
    Copy the full SHA
    808a968 View commit details
    Browse the repository at this point in the history