Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: hyphanet/plugin-WebOfTrust
base: ec38ccb6607b
Choose a base ref
...
head repository: hyphanet/plugin-WebOfTrust
compare: 80c1ab08cd8b
Choose a head ref
  • 2 commits
  • 4 files changed
  • 1 contributor

Commits on Mar 10, 2015

  1. (Own)IdentityTest.testClone(): Fix to show failure of preserving 

    mLastChangedDate

This fixes the said unit tests to demonstrate that (Own)Identity.clone()
does not preserve mLastChangedDate. The tests will now fail. This is
intentional and will be fixed in the following commit.

The failure of preserving the date only happens if an (Own)Identity has
a context/property, and the tests failed to add a context/property. This
also implicitly improves the tests to check whether clone() preserves
contexts/properties.

The new failures of the tests will be similar to:

junit.framework.AssertionFailedError: protected java.util.Date
plugins.WebOfTrust.Identity.mLastChangedDate expected:<Tue Mar 10
05:48:36 CET 2015> but was:<Tue Mar 10 05:48:36 CET 2015>
	at junit.framework.Assert.fail(Assert.java:47)
	at junit.framework.Assert.failNotEquals(Assert.java:280)
	at junit.framework.Assert.assertEquals(Assert.java:64)
	at plugins.WebOfTrust.AbstractJUnit3BaseTest
        .testClone(AbstractJUnit3BaseTest.java:117)
	at plugins.WebOfTrust.OwnIdentityTest
        .testClone(OwnIdentityTest.java:98)
    @xor-freenet
    xor-freenet committed Mar 10, 2015
    Copy the full SHA
    69ab18c View commit details
    Browse the repository at this point in the history

  2. (Own)Identity.clone(): Fix failure of preserving mLastChangedDate 

    - Fixes the web interface's "My identities" page always saying that
every identity was changed at the same moment when the page was
displayed
- Fixes (Own)IdentityTest.testClone() failures similar to:

junit.framework.AssertionFailedError: protected java.util.Date
plugins.WebOfTrust.Identity.mLastChangedDate expected:<Tue Mar 10
05:48:36 CET 2015> but was:<Tue Mar 10 05:48:36 CET 2015>
	at junit.framework.Assert.fail(Assert.java:47)
	at junit.framework.Assert.failNotEquals(Assert.java:280)
	at junit.framework.Assert.assertEquals(Assert.java:64)
	at plugins.WebOfTrust.AbstractJUnit3BaseTest
		.testClone(AbstractJUnit3BaseTest.java:117)
	at plugins.WebOfTrust.OwnIdentityTest
		.testClone(OwnIdentityTest.java:98)
    @xor-freenet
    xor-freenet committed Mar 10, 2015
    Copy the full SHA
    80c1ab0 View commit details
    Browse the repository at this point in the history