TRUNK-3980: Add back button support for patient search page #315
Conversation
TRUNK-3980: Add back button support for patient search page
|
|
||
| // Patient search doesn't support for Enter Key. So invoke keyup | ||
| // event with last character of searched text. | ||
| if (el.attr('id') === "findPatients") { |
There was a problem hiding this comment.
I don't really like this in the generic widget, we need to do it in another way e.g use a widget property, what are you trying to solve?
There was a problem hiding this comment.
Yes i fully agree that widget property is better!!!
There was a problem hiding this comment.
Wyclif,
I agree that hard coding this inside widget is not realy good. But do we really need a property to do this ? Because we already parse the id from the caller like new OpenmrsSearch("findPatients", ....etc. So, as I think we need a constant for string "findPatients" and we use it both at the caller and the widget.
There was a problem hiding this comment.
First all, why are you doing this? Do you mean the back button wouldn't work on the findPatients page, if yes then there is another problem because it means the same thing can show up on another search page and who knows you will end up many ifs to check for the id for other searches
There was a problem hiding this comment.
Previouse fix for the concept should supposed to be work for this as well. This is what you mean right. But the problem is there are some differents in the behaviour of those searches. findConcepts gives immediate results when click enter. But finPatient doesn't and also it breaks default search when click enter. If these two searches (and others as well) can support for result shoe when click enter, hopefully no modifications needs to openmrsSearch.js
Browser back button for the patient search page, now displaying the previousely search resuts.