Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: 8574cb3d77bb^
Choose a base ref
...
head repository: jruby/jruby
compare: 9717929a3c10
Choose a head ref
  • 4 commits
  • 4 files changed
  • 1 contributor

Commits on Mar 13, 2015

  1. Move String#inspect's "actual encoding" logic out and use it. 

    This is STR_ENC_GET/get_encoding/get_actual_encoding used in
several String methods. This fixes issues with the UTF-16/23 dummy
replicas confusing the transcoding system.
    @headius
    headius committed Mar 13, 2015
    Copy the full SHA
    8574cb3 View commit details
    Browse the repository at this point in the history

  2. Fix String#b to force the dup to modify. 

    Without modify here, the BINARY encoding gets applied to the
still-shared ByteList from the original. Caused various issues in
tests that use #b.
    @headius
    headius committed Mar 13, 2015
    Copy the full SHA
    f2350fe View commit details
    Browse the repository at this point in the history

  3. Integer#chr fixes for unusual encodings. 

    * Ensure int gets used as unsigned for 32-bit encodings.
* Double-check resulting character to be sure it is valid.
    @headius
    headius committed Mar 13, 2015
    Copy the full SHA
    f90bcc9 View commit details
    Browse the repository at this point in the history

  4. Incorporate MRI fix for bad single-byte string character counts. 

    See https://bugs.ruby-lang.org/issues/10078
    @headius
    headius committed Mar 13, 2015
    Copy the full SHA
    9717929 View commit details
    Browse the repository at this point in the history