-
-
Notifications
You must be signed in to change notification settings - Fork 925
Comparing changes
Open a pull request
base repository: jruby/jruby
base: f048d4f5987e
head repository: jruby/jruby
compare: 88bab9990347
Commits on Mar 3, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 54bcd35 - Browse repository at this point
Copy the full SHA 54bcd35View commit details -
Things we are minimally building and interpreting will now be more ob…
…vious BEGIN/END/eval
Configuration menu - View commit details
-
Copy full SHA for 6a494f9 - Browse repository at this point
Copy the full SHA 6a494f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for d823301 - Browse repository at this point
Copy the full SHA d823301View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6ebbb3 - Browse repository at this point
Copy the full SHA d6ebbb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for cba0983 - Browse repository at this point
Copy the full SHA cba0983View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8bf22fa - Browse repository at this point
Copy the full SHA 8bf22faView commit details -
Configuration menu - View commit details
-
Copy full SHA for b1f9c42 - Browse repository at this point
Copy the full SHA b1f9c42View commit details -
Configuration menu - View commit details
-
Copy full SHA for f9b3bfe - Browse repository at this point
Copy the full SHA f9b3bfeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c6a32c - Browse repository at this point
Copy the full SHA 8c6a32cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ac3bc8a - Browse repository at this point
Copy the full SHA ac3bc8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ad4c5c - Browse repository at this point
Copy the full SHA 5ad4c5cView commit details -
2
Configuration menu - View commit details
-
Copy full SHA for dee6c77 - Browse repository at this point
Copy the full SHA dee6c77View commit details -
Configuration menu - View commit details
-
Copy full SHA for 675a0eb - Browse repository at this point
Copy the full SHA 675a0ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c73e40 - Browse repository at this point
Copy the full SHA 3c73e40View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4462b99 - Browse repository at this point
Copy the full SHA 4462b99View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9854e78 - Browse repository at this point
Copy the full SHA 9854e78View commit details -
Configuration menu - View commit details
-
Copy full SHA for c1990ca - Browse repository at this point
Copy the full SHA c1990caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 766a91e - Browse repository at this point
Copy the full SHA 766a91eView commit details -
lots of rearrangement and state added to fullinterpretercontext and s…
…ome basic outline of flow in prepareFullBuild
Configuration menu - View commit details
-
Copy full SHA for e2964e5 - Browse repository at this point
Copy the full SHA e2964e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16def94 - Browse repository at this point
Copy the full SHA 16def94View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8355e22 - Browse repository at this point
Copy the full SHA 8355e22View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5168e0e - Browse repository at this point
Copy the full SHA 5168e0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 70539bb - Browse repository at this point
Copy the full SHA 70539bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for a6f82b8 - Browse repository at this point
Copy the full SHA a6f82b8View commit details -
Configuration menu - View commit details
-
Copy full SHA for e1d1877 - Browse repository at this point
Copy the full SHA e1d1877View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8f0060 - Browse repository at this point
Copy the full SHA d8f0060View commit details -
Configuration menu - View commit details
-
Copy full SHA for 112b450 - Browse repository at this point
Copy the full SHA 112b450View commit details -
Last sloppy commit. CFGBuilder removed from compilerpasses. JIT/Full …
…build race problem finally solved
Configuration menu - View commit details
-
Copy full SHA for 63c8149 - Browse repository at this point
Copy the full SHA 63c8149View commit details -
Unbreak the JI code so specs run again and comment out flip specs sin…
…ce they test flip migrating through eval (which is currently broken and is amazing it ever worked
Configuration menu - View commit details
-
Copy full SHA for 8c13270 - Browse repository at this point
Copy the full SHA 8c13270View commit details -
Enable OptimizeTempVarsPass again
* Fix use of the incorrect instruction list
Configuration menu - View commit details
-
Copy full SHA for 8e1e2f8 - Browse repository at this point
Copy the full SHA 8e1e2f8View commit details -
Fix incorrect CFG fetch in LocalOptimizationPass
* Now -X-C runs with all passes again.
Configuration menu - View commit details
-
Copy full SHA for 6ec9f98 - Browse repository at this point
Copy the full SHA 6ec9f98View commit details -
Add LocalOptimizationPass to default JIT passes
* Also renamed DEFAULT_COMPILER_PASSES to DEFAULT_BUILD_PASSES to clarify that these are passes that run for interpreter.
Configuration menu - View commit details
-
Copy full SHA for 107f4c0 - Browse repository at this point
Copy the full SHA 107f4c0View commit details -
OptimizeTempVarsPass doesn't need to run on child scopes upfront
* Let this run on child scopes on demand so that it follows the new lifecycle. * Eliminates crashers when run on closures from parent scopes.
Configuration menu - View commit details
-
Copy full SHA for 03bc9c6 - Browse repository at this point
Copy the full SHA 03bc9c6View commit details
Commits on Mar 4, 2015
-
CFG.toStringInstrs: Don't dump CFG of nested scopes
* This can be extremely distracting in debugging output. * Users of CFG debug output that need output from nested scopes should explicitly do it where required.
Configuration menu - View commit details
-
Copy full SHA for 2e4c5f9 - Browse repository at this point
Copy the full SHA 2e4c5f9View commit details -
Build full interpreter contexts for closures on demand
* No need to build full ICs for closures eagerly. * Had to add some null checks for access to ICs in a couple places when I experimented turning off passes on nested scopes (LocalOptimizationPass, AddLocalVarLoadStoreInstructionsPass). Keeps that code more robust and usable in different lifecycles.
Configuration menu - View commit details
-
Copy full SHA for 6a8701b - Browse repository at this point
Copy the full SHA 6a8701bView commit details -
Make LVA dependent on OptimizeDynScopesPass
* If LVA is to run independently on closures (without parent scopes), it needs info about whether dyn scopes have been eliminated or not (see access to IRFlags.DYNSCOPE_ELIMINATED in the code). So, making that dependency explicit.
Configuration menu - View commit details
-
Copy full SHA for 0dbe1b2 - Browse repository at this point
Copy the full SHA 0dbe1b2View commit details -
OptimizeTempVarsPass is now just a collection of static methods and n…
…ot inheriting from CompilerPass. clonedInstrs is no longer a field in IRScope and is a local in prepareFullBuildCommon.
Configuration menu - View commit details
-
Copy full SHA for 88eeb49 - Browse repository at this point
Copy the full SHA 88eeb49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9fd5d46 - Browse repository at this point
Copy the full SHA 9fd5d46View commit details -
Add new test:mri:int_full which is jit.threshold=0 to force full buil…
…d tests for full interpreter.
Configuration menu - View commit details
-
Copy full SHA for 43f0463 - Browse repository at this point
Copy the full SHA 43f0463View commit details -
Remove special fic check in getCFG. Partially brittle because I only …
…guard in LOP pass for closures
Configuration menu - View commit details
-
Copy full SHA for 974016f - Browse repository at this point
Copy the full SHA 974016fView commit details
Commits on Mar 5, 2015
-
* LVA was attempting to analyze closures in the context of their parent scope's LVA context. The code was general enough that if we knew more information about specific call sites, it would have done better. However, in reality, given that we don't know too much about call sites, (a) all that code was extra complexity (b) it was really doing anything in terms of not being conservative (because all calls are being treated as dataflow barriers right now) (c) in the only case where it would not have been conservative, it was actually making an incorrect assumption that the closure will execute at the call site where it is defined and hence incorrectly marking a variable dead when it wasn't. * The fix was to simply eliminate the analysis of closures in the context of the parent's scope. We already had support for independent LVA of closures which takes care of scenario (c) above by marking all dirtied vars live on "entry" (which in the case of LVA, which is a backwards pass, is the control flow exit). This now fixes the failing snippet (see below) and should also eliminate the remaining test:mri:jit failures. [subbu@earth ir] jruby -Xjit.threshold=0 -e "z = 5; x = Hash.new {|h,kk| z = kk }; z=0; x[22]; p z" 22 Conflicts: core/src/main/java/org/jruby/ir/dataflow/analyses/LiveVariableNode.java core/src/main/java/org/jruby/ir/passes/LiveVariableAnalysis.java
Configuration menu - View commit details
-
Copy full SHA for f48c871 - Browse repository at this point
Copy the full SHA f48c871View commit details -
Configuration menu - View commit details
-
Copy full SHA for 699c833 - Browse repository at this point
Copy the full SHA 699c833View commit details -
Configuration menu - View commit details
-
Copy full SHA for 566a3b6 - Browse repository at this point
Copy the full SHA 566a3b6View commit details -
Change LVA.previouslyRun check to return null if it has never made a …
…CFG before vs making on demand. The basic mechanics of CompilerPass on a null return will naturally run the pass on it which will generate the CFG on demand along with the data. Add comment in getCFG explaining when fic will be null. Comment out child closure passing from LOP because we don't want it but left it comments out because it exposes some lifecycle problems. Once we stabilize hypernugget and merge back to master we will dig into this problem more.
Configuration menu - View commit details
-
Copy full SHA for 0c83a8c - Browse repository at this point
Copy the full SHA 0c83a8cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7789ebe - Browse repository at this point
Copy the full SHA 7789ebeView commit details -
Make IRScope.getLiveVariablesProblem add convenience cast to LiveVari…
…ablesProblem. Remove DataFlowConstants since it was already mostly dead. Hook up more LVP getters to reduce externalized use of FIC.
Configuration menu - View commit details
-
Copy full SHA for 0b65fe8 - Browse repository at this point
Copy the full SHA 0b65fe8View commit details -
Configuration menu - View commit details
-
Copy full SHA for cd796d0 - Browse repository at this point
Copy the full SHA cd796d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for a5e6a7b - Browse repository at this point
Copy the full SHA a5e6a7bView commit details -
New IRScope.{get,put}StoreLocalVarPlacementProblem. fic is only refer…
…ences in IRScope now.
Configuration menu - View commit details
-
Copy full SHA for 2be82aa - Browse repository at this point
Copy the full SHA 2be82aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 27504e2 - Browse repository at this point
Copy the full SHA 27504e2View commit details
There are no files selected for viewing