Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 02fde585b15f
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: a9eb96d0201f
Choose a head ref
  • 5 commits
  • 6 files changed
  • 1 contributor

Commits on Aug 29, 2013

  1. crypto: make error buffer non-static 

    Doesn't matter now but it will if/when we have support for multiple
threads.
    @bnoordhuis
    bnoordhuis committed Aug 29, 2013
    Copy the full SHA
    699f636 View commit details
    Browse the repository at this point in the history

  2. crypto: remove misleading comment

    @bnoordhuis
    bnoordhuis committed Aug 29, 2013
    Copy the full SHA
    21911db View commit details
    Browse the repository at this point in the history

  3. crypto: make root_cert_store variable extern 

    Before this commit it was declared static (in a header file!), meaning
it got duplicated in every file that includes it.

A few duplicated pointers is not the end of the world but it introduces
a lot of potential for confusion because root_cert_store in file A is
not the root_cert_store in file B.

Moral of the story: don't declare static variables in header files.
    @bnoordhuis
    bnoordhuis committed Aug 29, 2013
    Copy the full SHA
    8e596c4 View commit details
    Browse the repository at this point in the history

  4. crypto: remove NodeBIO::GetMethod() 

    Remove NodeBIO::GetMethod() and replace calls to BIO_new() with calls
to the new NodeBIO::New() function.

This commit basically reshuffles some code in order to make it explicit
that the NodeBIO BIO_METHOD is const.
    @bnoordhuis
    bnoordhuis committed Aug 29, 2013
    Copy the full SHA
    653f62a View commit details
    Browse the repository at this point in the history

  5. src: remove unused Persistent<FunctionTemplate>

    @bnoordhuis
    bnoordhuis committed Aug 29, 2013
    Copy the full SHA
    a9eb96d View commit details
    Browse the repository at this point in the history